-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registration): Add Chain registrar contract #1064
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Danil <[email protected]> Co-authored-by: Vlad Bochok <[email protected]>
Signed-off-by: Danil <[email protected]> Co-authored-by: Vlad Bochok <[email protected]>
Signed-off-by: Danil <[email protected]> Co-authored-by: Vlad Bochok <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]> Co-authored-by: Bence Haromi <[email protected]> Co-authored-by: Grzegorz Prusak <[email protected]> Co-authored-by: Moshe Shababo <[email protected]> Co-authored-by: Akosh Farkash <[email protected]> Co-authored-by: Bruno França <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: Roman Brodetski <[email protected]> Co-authored-by: vladbochok <[email protected]> Co-authored-by: Stanislav Bezkorovainyi <[email protected]> Co-authored-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]> Co-authored-by: otani <[email protected]> Co-authored-by: Zach Kolodny <[email protected]>
Signed-off-by: Danil <[email protected]>
Co-authored-by: Vlad Bochok <[email protected]>
feat: add timestamp asserter contract
…sserter-command fix: add deploy timestamp asserter command
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update comments to follow napspec specificaion. Comment all function parameters by /// @param
.
4bd2894
to
b13245c
Compare
Signed-off-by: Danil <[email protected]>
b13245c
to
6ed3ebc
Compare
Signed-off-by: Danil <[email protected]>
d831ef1
to
1fabb69
Compare
Signed-off-by: Danil <[email protected]>
1fabb69
to
8ceaa5b
Compare
Signed-off-by: Danil <[email protected]>
0045c83
to
2b54930
Compare
bd8fe8d
to
0bfe491
Compare
Signed-off-by: Danil <[email protected]>
0bfe491
to
3388f52
Compare
revert ChainIsAlreadyDeployed(); | ||
} | ||
|
||
proposedChains[msg.sender][_chainId] = config; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to allow user to re-propose config? I would rather restrict it to make avoid any confusion on the final config (as soon as config is onchain it immutable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, let's restrict it, i initially thought about it, as a way to give an ability to change it and then make a deployment period when they can't change it. but probably it'd be easier to simply restring it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deniallugo this should be fixed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit: please use external
modifier when possible. This is general recomendation for all Solidity code, since external
can be called inside the code only as child call while public
allows the same call as internal
Co-authored-by: Vlad Bochok <[email protected]>
Signed-off-by: Danil <[email protected]>
01f301a
to
f0b38c0
Compare
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
What ❔
Add Chain registrar contracts, that allow partners to register their chains and then configure their chain from L1
Why ❔
For making our registration process a bit more transparent and later on make it even easier
Checklist