-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch storage strategy #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LastTalon
reviewed
Jul 15, 2024
LastTalon
reviewed
Jul 15, 2024
jackTabsCode
reviewed
Oct 4, 2024
Ukendio
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jackTabsCode
added a commit
to jackTabsCode/rbxts-matter
that referenced
this pull request
Oct 21, 2024
Co-authored-by: Marcus <[email protected]> Co-authored-by: Jack T <[email protected]>
Ukendio
added a commit
that referenced
this pull request
Oct 21, 2024
Co-authored-by: Marcus <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR completely changes the internal storage layout to optimize queries. The goal is to be able to iterate the entities in each archetype in a cache friendly way and with as little indirection as possible
At its core, an archetype stores data as a map from a component -> map from an entity -> component data (
fields
in the code). However, we assign contiguous indices to each component and to each entity so that the maps are effectively arrays.All of the supporting structures in an archetype are to make this densely packed layout possible. For instance,
idToIndex
maps a component ID to its index infields
.Performance
Iterating ~7,400 entities with 128 archetypes is 7.5x faster. More synthetic benchmarks show 10-15x improvement.
Next steps
There are plenty of optimizations that can still be made. Some will come at the expense of readability and have been left out of this implementation to keep the focus clear, while others were omitted simply due to time constraints and the desire to keep this PR as small as possible.
The most obvious and immediate follow-up is to implement an archetype graph so that insertions and removals can be much faster.
Thanks to @Ukendio for guidance and @SanderMertens for the great articles upon which this implementation is based on.