Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archetype Invariants #4

Merged
merged 65 commits into from
Apr 14, 2024
Merged

Archetype Invariants #4

merged 65 commits into from
Apr 14, 2024

Conversation

Ukendio
Copy link
Member

@Ukendio Ukendio commented Jan 7, 2024 •
edited
Loading

Blocked before QueryResult is reworked.

This PR resolves #11. In every case performs better than existing queries. Scales relatively to how many entities you filter from :without
image
image

Benchmark file: https://drive.google.com/file/d/1JJbPvVdSCS0kRd6HgMQ2bGEhDmhk1kmy/view?usp=sharing

Passes every unit test currently, but waiting to hear feedback from others to test it in real production code.

Ukendio added 30 commits December 20, 2023 06:15
@Ukendio
Add check for config
9a84577
@Ukendio
Prototyped implementation
89c3f2c
@Ukendio
Remove whitspace
3b8d5d7
@Ukendio
Added unit tests
28e1c9e
@Ukendio
Preserve order of query traversal
7a93fd7
@Ukendio
Merge branch 'main' of https://github.com/evaera/matter into views
a46a97a
@Ukendio
Adding comments
aa3d0f4
@Ukendio
Merge branch 'main' of https://github.com/evaera/matter into views
0a2f6df
@Ukendio
Remove entity param from view
4868ba6
@Ukendio
Oops.
7f67d1d
@Ukendio
Add "_" to unused variables
e70a590
@Ukendio
Change otherRoot name in tests
84e1c36
@Ukendio
Merge branch 'main' of https://github.com/evaera/matter into views
79822a7
@Ukendio
Put keys in a linked list
817d1df
@Ukendio
Add checks for views:get()
e7889b9
@Ukendio
Initial Commit
09bd251
@Ukendio
iterate self._filter instead of entityData
ad24560
@Ukendio
Create a NOOP
ebb1f85
@Ukendio
Remove unused function
03a31b5
@Ukendio
Moved functions under corresponding comments
e0ed459
@Ukendio
Initial commit
bdae1c4
@Ukendio
Expand should be a closure for inlining
fe4ec1d
@Ukendio
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
0c97ff7 
…chetype-negation
@Ukendio
Make :_next into a closure instead
fad7489
@Ukendio
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
4e9eecf 
…chetype-negation
@Ukendio
remove topoRuntime import
a7fe37a
@Ukendio
Make struct smaller
1cc5144
@Ukendio
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
ac1d737 
…chetype-negation
@Ukendio
Change split to ||
a53ce69
@Ukendio
Merge branch 'views' of https://github.com/evaera/matter into archety…
ef5d8fe 
…pe-negation
@jackTabsCode jackTabsCode added the improvement An imperfection we can make better label Jan 27, 2024
@Ukendio Ukendio added this to the v0.8.0 milestone Feb 2, 2024
@Ukendio
Revert "Merge branch 'views' of https://github.com/evaera/matter into…
61af0ee 
… archetype-negation"

This reverts commit ef5d8fe, reversing
changes made to a53ce69.
@Ukendio Ukendio removed the blocked Another issue is preventing this label Feb 9, 2024
jackTabsCode
jackTabsCode previously approved these changes Mar 19, 2024
View reviewed changes
@Ukendio Ukendio changed the title Archetype Negation Archetype Invariants Apr 2, 2024
@Ukendio Ukendio modified the milestones: v0.8.0, v0.7.2 Apr 14, 2024
@Ukendio Ukendio merged commit 83338bb into main Apr 14, 2024
6 checks passed
@Ukendio Ukendio deleted the archetype-negation branch April 14, 2024 15:57
@Ukendio Ukendio modified the milestones: v0.7.2, v0.8.0 Apr 21, 2024
@LastTalon LastTalon removed their request for review June 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackTabsCode jackTabsCode jackTabsCode approved these changes

@metrowaii metrowaii Awaiting requested review from metrowaii

Assignees
No one assigned
Labels
improvement An imperfection we can make better
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Without should narrow archetypes
2 participants
@Ukendio @jackTabsCode