Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize system names #134

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Memoize system names #134

merged 5 commits into from
Nov 15, 2024

Conversation

jackTabsCode
Copy link
Contributor

@jackTabsCode jackTabsCode commented Oct 29, 2024

Only call systemName() once, when the system is scheduled. debug.info() is expensive.

Helps #133, but does not close it, because this is only a small part of the problem.

@jackTabsCode jackTabsCode requested a review from a team October 29, 2024 23:14
@jackTabsCode
Copy link
Contributor Author

Running into an issue with hot reloading
image
Note for myself

@jackTabsCode jackTabsCode marked this pull request as draft October 30, 2024 00:32
@jackTabsCode jackTabsCode marked this pull request as ready for review November 10, 2024 22:32
Copy link
Contributor

@memorycode memorycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs to be updated before we can merge

@jackTabsCode jackTabsCode merged commit c793b25 into main Nov 15, 2024
6 checks passed
@jackTabsCode jackTabsCode deleted the reduce-system-name-calls branch November 15, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants