Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate error in hoverInspect when entity no longer exists #103

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Mitigate error in hoverInspect when entity no longer exists #103

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7c0946
Mitigate error in `hoverInspect` when entity no longer exists
Nidoxs Aug 10, 2024
baa5357
Merge branch 'main' into highlight-error-fix
Nidoxs Aug 10, 2024
ba2c090
Merge branch 'main' into highlight-error-fix
Nidoxs Aug 10, 2024
0c774a7
Move contains check higher up in the debugger logic (avoid no-op plas…
Nidoxs Aug 11, 2024
47e8022
Improve robustness of contains check
Nidoxs Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/debugger/ui.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ local function ui(debugger, loop)

local objectStack = plasma.useState({})
local worldViewOpen, setWorldViewOpen = plasma.useState(false)
local worldExists = debugger.debugWorld ~= nil

if debugger.hoverEntity then
custom.hoverInspect(debugger.debugWorld, debugger.hoverEntity, custom)
if debugger.hoverEntity and worldExists then
if debugger.debugWorld:contains(debugger.hoverEntity) then
custom.hoverInspect(debugger.debugWorld, debugger.hoverEntity, custom)
end
end

custom.container(function()
Expand Down
Loading