Choice of the cache directory #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenollp
reviewed
Sep 29, 2016
| char filename[] = "/tmp/mega.XXXXXX"; | ||
| close (mkstemp(filename)); | ||
| std::string filename = Config::getInstance()->CACHEPATH + "/mega.XXXXXX"; | ||
| close (mkstemp(&filename[0])); |
There was a problem hiding this comment.
Well… possibly ;-)
I did what I could with my Java knowledge and a fair bit of research+help.
Feel free to submit corrections :-)
However, this pull-request is closed, as it has been merged into MegaFuse already. So I suppose you’ll have to create another pull-request.
Cheers,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My server has a very small /tmp, which caused MegaFuse to fail after a time. Unfortunately, I saw that "/tmp" was hardcoded.
I have next to no knowledge in C++, but with the help of others, I managed to adapt the software to my needs. So far it seems to work fine.
If you don't spot problems in the changes, I would be glad if you would include these.