Skip to content

Commit

Permalink
Merge pull request #45 from /issues/44
Browse files Browse the repository at this point in the history
Issues/44 Not working on Unity 2018.3.3f1 #44
  • Loading branch information
mattak authored Feb 21, 2019
2 parents b9882d2 + b95f112 commit d262bf1
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 12 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ sysinfo.txt
Assets/Plugins/Editor.meta
Assets/Plugins/Editor/

Logs/
4 changes: 2 additions & 2 deletions Assets/Editor/Test/FileCacheTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public FileCacheForTest(GameObject gameObject, string rootDirectory, ICacheEncod
{
}

protected override UniRx.IObservable<Command> AsyncSetCommandGetCacheByPath(UniRx.IObservable<Command> observable)
protected override IObservable<Command> AsyncSetCommandGetCacheByPath(IObservable<Command> observable)
{
return observable.Select(_command => this.SetCommandGetCacheByPath(_command));
}
Expand All @@ -197,7 +197,7 @@ protected override void AsyncDeleteAndSetCache(GameObject obj, Command command)

class TestCacheHandler : ICacheHandler
{
public UniRx.IObservable<byte[]> Fetch(string key)
public IObservable<byte[]> Fetch(string key)
{
if (key.Equals("foo"))
{
Expand Down
6 changes: 3 additions & 3 deletions Assets/Plugins/Unicache/Scripts/FileCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public FileCache(GameObject gameObject, string rootDirectory, ICacheEncoderDecod
this.BuildQueue(gameObject);
}

public UniRx.IObservable<byte[]> Fetch(string key)
public IObservable<byte[]> Fetch(string key)
{
var url = this.UrlLocator.CreateUrl(key);
var path = this.CacheLocator.CreateCachePath(key);
Expand Down Expand Up @@ -165,8 +165,8 @@ private void BuildQueue(GameObject obj)
.AddTo(obj);
}

protected virtual UniRx.IObservable<Command> AsyncSetCommandGetCacheByPath(
UniRx.IObservable<Command> observable)
protected virtual IObservable<Command> AsyncSetCommandGetCacheByPath(
IObservable<Command> observable)
{
return observable
.ObserveOn(Scheduler.ThreadPool)
Expand Down
2 changes: 1 addition & 1 deletion Assets/Plugins/Unicache/Scripts/ICacheHandler.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using UniRx;
using System;

namespace Unicache
{
Expand Down
4 changes: 2 additions & 2 deletions Assets/Plugins/Unicache/Scripts/IUnicache.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using System.Collections.Generic;
using UniRx;
using System;
using System.Collections.Generic;

namespace Unicache
{
Expand Down
3 changes: 2 additions & 1 deletion Assets/Plugins/Unicache/Scripts/MemoryCache.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using Unicache.Plugin;
using UniRx;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using UniRx;
using System;
using UniRx;
using UnityEngine;

namespace Unicache.Plugin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ private IEnumerator FetchCoroutine(string url, Action<byte[]> callback, Action<E
{
UnityWebRequest request = UnityWebRequest.Get(url);

yield return request.Send();
yield return request.SendWebRequest();

if (isSuccess(request))
{
Expand Down
Binary file added ProjectSettings/PresetManager.asset
Binary file not shown.
2 changes: 1 addition & 1 deletion ProjectSettings/ProjectVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
m_EditorVersion: 2017.1.1f1
m_EditorVersion: 2018.3.5f1
Binary file added ProjectSettings/VFXManager.asset
Binary file not shown.

0 comments on commit d262bf1

Please sign in to comment.