Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if thumbnail is GdImage #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhoekx
Copy link
Contributor

@jhoekx jhoekx commented Jun 12, 2021

In PHP 8, GD returns GdImage objects and not resources. To check if a thumbnail could be created, is_resource() was used. Since the thumbnail is no longer a resource, this check now fails and the default thumbnail was used for all uploaded maps.

See https://php.watch/versions/8.0/gdimage#gdimage-is-resource

Note that I only have access to a system with PHP 8. According to the linked document, this fix works in PHP 7 as well, but was not tested by me. Not sure about earlier versions.

In PHP 8, GD returns GdImage objects and not resources. To check if a
thumbnail could be created, `is_resource()` was used. Since the
thumbnail is no longer a resource, this check now fails and the default
thumbnail was used for all maps.

See https://php.watch/versions/8.0/gdimage#gdimage-is-resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant