Parking capacities #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschlenther
approved these changes
Jan 24, 2024
| minCapacity = usableLength /50; | ||
| } | ||
|
|
||
| l.getAttributes().putAttribute("maxParkingCapacity", Math.floor(maxCapacity)); |
There was a problem hiding this comment.
is it intended to write the capacity as double? Did you consider an integer?
|
|
||
| l.getAttributes().putAttribute("maxParkingCapacity", Math.floor(maxCapacity)); | ||
| l.getAttributes().putAttribute("minParkingCapacity", Math.floor(minCapacity)); | ||
| listOfParkingCapacities.add(new ParkingCapacityRecord(l.getId().toString(), (int) Math.floor(maxCapacity), (int) Math.floor(minCapacity))); |
There was a problem hiding this comment.
i would recommend to do the cast and the computation further above, when you set the values for maxCapacity and minCapacity, i.e. in lines 33 and 34, respectively. You'd have to convert their types to int then. This will then need fewer calls of Math.floor() and also would be more clean and intuitive (to me).
|
please consider squashing the commits when merging ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.