Emission noise analysis #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kt86
reviewed
Aug 22, 2024
Comment on lines
+189
to
+201
|
|
||
| if (emissions == EmissionAnalysisHandling.PERFORM_EMISSIONS_ANALYSIS) { | ||
| // do not use VspHbefaRoadTypeMapping() as it results in almost every road to mapped to "highway"! | ||
| HbefaRoadTypeMapping roadTypeMapping = OsmHbefaMapping.build(); | ||
| // the type attribute in our network has the prefix "highway" for all links but pt links. | ||
| // we need to delete that because OsmHbefaMapping does not handle that. | ||
| for (Link link : scenario.getNetwork().getLinks().values()) { | ||
| //pt links can be disregarded | ||
| if (!link.getAllowedModes().contains("pt")) { | ||
| NetworkUtils.setType(link, NetworkUtils.getType(link).replaceFirst("highway.", "")); | ||
| } | ||
| } | ||
| roadTypeMapping.addHbefaMappings(scenario.getNetwork()); |
There was a problem hiding this comment.
As also written directly to Simon: We at VSP should have our current scenarios in a state, that the HBEFA attributes are part of the input network. This is a network property and thus should not depend on the mapping in the analysis script itself.
kt86
reviewed
Aug 22, 2024
Comment on lines
+274
to
+314
| for (VehicleType type : scenario.getVehicles().getVehicleTypes().values()) { | ||
| EngineInformation engineInformation = type.getEngineInformation(); | ||
|
|
||
| // only set engine information if none are present | ||
| if (engineInformation.getAttributes().isEmpty()) { | ||
| switch (type.getId().toString()) { | ||
| case TransportMode.car -> { | ||
| VehicleUtils.setHbefaVehicleCategory(engineInformation, HbefaVehicleCategory.PASSENGER_CAR.toString()); | ||
| VehicleUtils.setHbefaTechnology(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaSizeClass(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaEmissionsConcept(engineInformation, AVERAGE); | ||
| } | ||
| case TransportMode.ride -> { | ||
| // ignore ride, the mode routed on network, but then teleported | ||
| VehicleUtils.setHbefaVehicleCategory(engineInformation, HbefaVehicleCategory.NON_HBEFA_VEHICLE.toString()); | ||
| VehicleUtils.setHbefaTechnology(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaSizeClass(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaEmissionsConcept(engineInformation, AVERAGE); | ||
| } | ||
| case FREIGHT -> { | ||
| VehicleUtils.setHbefaVehicleCategory(engineInformation, HbefaVehicleCategory.HEAVY_GOODS_VEHICLE.toString()); | ||
| VehicleUtils.setHbefaTechnology(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaSizeClass(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaEmissionsConcept(engineInformation, AVERAGE); | ||
| } | ||
| case TransportMode.bike -> { | ||
| // ignore bikes | ||
| VehicleUtils.setHbefaVehicleCategory(engineInformation, HbefaVehicleCategory.NON_HBEFA_VEHICLE.toString()); | ||
| VehicleUtils.setHbefaTechnology(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaSizeClass(engineInformation, AVERAGE); | ||
| VehicleUtils.setHbefaEmissionsConcept(engineInformation, AVERAGE); | ||
| } | ||
| default -> throw new IllegalArgumentException("does not know how to handle vehicleType " + type.getId().toString()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // ignore all pt veh types | ||
| scenario.getTransitVehicles() | ||
| .getVehicleTypes() | ||
| .values().forEach(type -> VehicleUtils.setHbefaVehicleCategory(type.getEngineInformation(), HbefaVehicleCategory.NON_HBEFA_VEHICLE.toString())); |
There was a problem hiding this comment.
A bit the same as for the links... should be IMO part of the input. Since this script here only sets average values, if no value is set, I do not know if the input has the engineInformation set correctly or not.
Maybe also make a bit more clear that you set here everything to average.
Comment on lines
+164
to
+165
| eConfig.setDetailedColdEmissionFactorsFile(HBEFA_FILE_COLD_DETAILED); | ||
| eConfig.setDetailedWarmEmissionFactorsFile(HBEFA_FILE_WARM_DETAILED); |
There was a problem hiding this comment.
If you only use AVERAGE, you should be able to run it without the detailed tables.
| eConfig.setAverageColdEmissionFactorsFile(HBEFA_FILE_COLD_AVERAGE); | ||
| eConfig.setAverageWarmEmissionFactorsFile(HBEFA_FILE_WARM_AVERAGE); | ||
| eConfig.setHbefaTableConsistencyCheckingLevel(EmissionsConfigGroup.HbefaTableConsistencyCheckingLevel.consistent); | ||
| eConfig.setDetailedVsAverageLookupBehavior(EmissionsConfigGroup.DetailedVsAverageLookupBehavior.tryDetailedThenTechnologyAverageThenAverageTable); |
There was a problem hiding this comment.
If only running AVERAGE vehicle types, the LookupBehaviour could be set IMO to directlyAverage (or whatever its name is). Together with just setting the average tables, it makes a bit more clear, that you run an average analysis (which is totally fine!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add emission and noise analysis + dashboards for each to analysis cycle.