Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Kelheim-specific emission dashboard #70

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

tschlenther
Copy link
Contributor

the rasters are still plotted via XYTime.class and not via GridMap.class, as we are still using older MATSim.

@tschlenther tschlenther requested a review from rakow April 25, 2024 11:55
Copy link
Contributor

@rakow rakow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yo, PR looks good. I think the goal should be to fix the issues upstream and make things as configurable as you need so you don't need to copy the dashboard + analysis in the future. @frievoe97 already started to improve on some of the issues, but it is not ready yet.

@tschlenther
Copy link
Contributor Author

But Kelheim needs specific assumptions for the emission analysis in terms of the network and the vehicles, which is why we need our own emission analysis script which needs to get called by simwrapper...

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.6% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@tschlenther tschlenther merged commit 12e947b into master Apr 30, 2024
3 of 4 checks passed
@tschlenther tschlenther deleted the emissionAnalysis branch April 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants