-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade x25519-dalek to 2.0.0-pre.1 #81
Conversation
Oh, looks like |
It is, also that tag/release has been in the |
Yeah it has, but I think we're better off with a release that's stable¹ but declared "pre" rathen than a proper release that's constantly causing issues (albeit only at build time). ¹ I would declare it as such based on the trivial diff from the stable release |
What kind of issues are we talking about? |
Not being able to upgrade other dependencies because their latest version requires |
sigh looks like we'd also need to use dalek-cryptography/ed25519-dalek#160 (through our own fork, I guess). I would still prefer that to the current state of things, but I understand if you don't want to go that route. Let me know if I should continue. |
I think curve25519-dalek will need to get the same treatment. I would let that simmer a bit longer, maybe something happens: WebAssembly/wasi-crypto#63. |
curve25519-dalek seems to also have a pre-release using the latest version of |
Alright, let's see where this goes: RustCrypto/elliptic-curves#497 (comment) I'll close this for now. |
The changes from the currently-used version are trivial, but they're required to upgrade to the latest version of zeroize in dependent crates.