Optimising the DB Search

[Rustix69]

Advantages :

• Fixes : Slow call to olmMachine.getRoomSettings() #4337
• Instead of calling object_store and get separately in different lines, the code groups them together in a single chain. This makes the code more concise and improves readability.
• The ? operator is used after each method to propagate errors immediately if any of the calls fail, avoiding unnecessary logic or nesting.
• We avoid multiple method calls and unnecessary intermediate variables. The result of get() is directly assigned, which will later be handled by the map() and transpose() methods.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (0264e49) to head (28f55d0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4388   +/-   ##
=======================================
  Coverage   85.27%   85.28%           
=======================================
  Files         282      282           
  Lines       31209    31209           
=======================================
+ Hits        26615    26618    +3     
+ Misses       4594     4591    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

Thanks for the patch, but I don't see how it changes anything to the actual code.

[Rustix69]

Thanks for the patch, but I don't see how it changes anything to the actual code.

Actually this PR is improving the readability and the error handling of the process which somewhat improving its optimization.

We can use Cache Memory by Hashmaps to improve the DB calls should I go with that method ?

[Hywan]

Actually this PR is improving the readability and the error handling of the process which somewhat improving its optimization.

I need proof of that. Readibility, yes, a bit, but I'm not sure it improves optimization from the compiler. From the compiler point of view, once reduced to a simple form, there is no difference between the two versions.

[Rustix69]

Actually this PR is improving the readability and the error handling of the process which somewhat improving its optimization.

I need proof of that. Readibility, yes, a bit, but I'm not sure it improves optimization from the compiler. From the compiler point of view, once reduced to a simple form, there is no difference between the two versions.

Sir Can I use Cache Hashmaps to improve optimization ?

[Hywan]

You can try for sure. I cannot merge this PR since it doesn't do anything useful and clearly not what the description claims.