Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another entrypoint using wasm-as-esm support #178

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 10, 2024

Some environments support loading WASM modules directly as ESM, and that gives better results than the existing entry points. For example, Webpack is able to include it inside the same bundle as the rest of the sources.

@richvdh richvdh requested a review from a team as a code owner December 10, 2024 21:36
@richvdh richvdh requested a review from bnjbvr December 10, 2024 21:36
Some environments support loading WASM modules directly as ESM, and that gives
better results than the existing entry points. For example, Webpack is able to
include it inside the same bundle as the rest of the sources.
index-wasm-esm.mjs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@bnjbvr bnjbvr removed their request for review December 11, 2024 09:44
@richvdh richvdh requested a review from sandhose December 11, 2024 11:54
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't pretend to understand much of this, but certainly nothing concerning from a Crypto point of view.

@richvdh richvdh merged commit 8142a01 into main Dec 11, 2024
3 checks passed
@richvdh richvdh deleted the rav/wasm-esm branch December 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants