Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI jobs to use yarn, to match the recommendation in the README #155

Merged
merged 1 commit into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,17 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v3

- name: Install NPM dependencies
run: npm install
- name: Install yarn
run: npm install --global yarn

- name: Install dependencies
run: yarn install

- name: Run eslint
run: npm run lint:eslint
run: yarn lint:eslint

- name: Run prettier
run: npm run lint:prettier
run: yarn lint:prettier

test:
name: test
Expand Down Expand Up @@ -75,20 +78,23 @@ jobs:
with:
node-version: 20.0

- name: Install NPM dependencies
run: npm install
- name: Install yarn
run: npm install --global yarn

- name: Install dependencies
run: yarn install

- name: Build the WebAssembly + JavaScript binding
run: npm run build
run: yarn build

- name: Check typescript types
run: npm run lint:types
run: yarn lint:types

- name: Test the JavaScript binding
run: npm run test
run: yarn test

- name: Build the documentation
run: npm run doc
run: yarn doc

docs:
name: docs
Expand Down Expand Up @@ -121,10 +127,13 @@ jobs:
with:
save-if: ${{ github.ref == 'refs/heads/main' }}

- name: Install yarn
run: npm install --global yarn

- name: Build `matrix-sdk-crypto-js` doc
run: |
npm install
npm run build && npm run doc
yarn install
yarn build && yarn doc

- name: Upload artifact
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ jobs:
with:
node-version: 20.0

- name: Install NPM dependencies
run: npm install
- name: Install yarn
run: npm install --global yarn

- name: Install dependencies
run: yarn install

- name: Publish the WebAssembly + JavaScript binding (imply building + testing)
uses: JS-DevTools/npm-publish@v1
Expand Down
Loading