Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring up-to-date with latest matrix-sdk (5d46b35d) #149

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Bring up-to-date with latest matrix-sdk (5d46b35d) #149

merged 1 commit into from
Oct 8, 2024

Conversation

andybalaam
Copy link
Member

In my quest to make method names consistent I first needed to reflect previous changes from matrix-sdk.

@andybalaam andybalaam requested a review from a team as a code owner October 4, 2024 14:54
@andybalaam andybalaam requested a review from richvdh October 4, 2024 14:54
richvdh
richvdh requested changes Oct 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@andybalaam andybalaam requested a review from richvdh October 7, 2024 10:50
richvdh
richvdh requested changes Oct 7, 2024
View reviewed changes
src/error.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
richvdh
richvdh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reference to UserIdentity in the documentation for OlmMachine.get_identity which will need an update.

LGTM otherwise.

@richvdh
Copy link
Member

richvdh commented Oct 7, 2024

(if you converted that reference to be a proper {@link ...}, like some of the other docs, then this sort of nonsense would be caught by CI)

@andybalaam andybalaam force-pushed the andybalaam/matrix-sdk-5d46b35d branch from ac4ff67 to d7eca6f Compare October 8, 2024 10:38
@andybalaam andybalaam enabled auto-merge October 8, 2024 10:39
@andybalaam andybalaam merged commit c650b55 into main Oct 8, 2024
3 checks passed
@andybalaam andybalaam deleted the andybalaam/matrix-sdk-5d46b35d branch October 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @richvdh