Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fixes #146

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Minor documentation fixes #146

merged 2 commits into from
Sep 24, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Sep 18, 2024

A handful of fixes to the doc-comments.

@richvdh richvdh requested a review from a team as a code owner September 18, 2024 16:20
@richvdh richvdh requested a review from andybalaam September 18, 2024 16:20
uhoreg
uhoreg previously requested changes Sep 18, 2024
src/identities.rs Outdated Show resolved Hide resolved
src/identities.rs Outdated Show resolved Hide resolved
src/identities.rs Outdated Show resolved Hide resolved
src/identities.rs Outdated Show resolved Hide resolved
@richvdh
Copy link
Member Author

richvdh commented Sep 24, 2024

Think I've addressed @uhoreg's comments, so merging this.

It makes no sense to supply example Rust in the Javascript bindings, and the
presence of this makes tsdoc emit warnings.
@richvdh richvdh enabled auto-merge (rebase) September 24, 2024 16:40
@richvdh richvdh merged commit dfe8404 into main Sep 24, 2024
3 checks passed
@richvdh richvdh deleted the rav/doc_fixes branch September 24, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants