Only report undecryptable events once #12501
Conversation
uhoreg
added
the
T-Task
|
TypeScript check fails due to something wrong in a dependency (I suspect there's a mistake in a type definition). Not sure what's the best way to fix this. |
I've filed Callidon/bloom-filters#72 about this, and pinned |
There really doesn't seem to be much point to this batching up of decryption failure reports. We still call the analytics callback the same number of times.
This *does* overlap with `failures`.
... otherwise they interfere
|
This seems to work now. |
| @@ -182,6 +183,7 @@ | |||
| "@types/react-transition-group": "^4.4.0", | |||
| "@types/sanitize-html": "2.11.0", | |||
| "@types/sdp-transform": "^2.4.6", | |||
| "@types/seedrandom": "<3.0.5", | |||
There was a problem hiding this comment.
this is pinned to work around Callidon/bloom-filters#72
There was a problem hiding this comment.
This sounds like it should have been in resolutions rather than dev deps
There was a problem hiding this comment.
#12551 is why - renovate is going to keep trying to update it.
|
Since I've written a good portion of this, could I get review from someone who isn't me or @uhoreg please? |
Fixes element-hq/element-web#27421
Stores the events in a scalable Bloom filter, rather than as a set. The scalable Bloom filter expands its capacity as items are added, to avoid false-positives, without needing to pre-allocate space. The JSON-encoded version of the Bloom filter takes about 8 characters per entry, as opposed to >40 characters if we stored it as an array of event IDs.
Checklist
public/exportedsymbols have accurate TSDoc documentation.