Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor matrixRTCSession Part3(v2): Move own membership logic into MyMembershipManager #4608

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[WIP] Refactor matrixRTCSession Part3(v2): Move own membership logic into MyMembershipManager #4608

wants to merge 5 commits into from
+384 −343

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jan 8, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part3.5-seperate-myMembershipManager branch from dd398ab to b1fd6a3 Compare January 8, 2025 17:37
@toger5 toger5 mentioned this pull request Jan 8, 2025
Closed
4 tasks
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part3.5-seperate-myMembershipManager branch from b1fd6a3 to f31dbf6 Compare January 8, 2025 17:51
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part3.5-seperate-myMembershipManager branch from f31dbf6 to 6f119f7 Compare January 8, 2025 17:52
@toger5 toger5 marked this pull request as ready for review January 8, 2025 17:52
@toger5 toger5 requested a review from a team as a code owner January 8, 2025 17:52
@toger5 toger5 requested a review from hughns January 8, 2025 17:52
@hughns hughns added the T-Task Tasks for the team like planning label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughns hughns Awaiting requested review from hughns hughns is a code owner automatically assigned from matrix-org/element-call-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @hughns