Device Dehydration | js-sdk: store/load dehydration key #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
reviewed
Jan 2, 2025
| const keyB64 = await this.secretStorage.get(SECRET_STORAGE_NAME); | ||
| if (keyB64 === undefined) { | ||
| if (!create) { | ||
| return null; | ||
| } | ||
| await this.resetKey(); | ||
| } else { | ||
| this.key = decodeBase64(keyB64); | ||
| const bytes = decodeBase64(keyB64); | ||
| const key = RustSdkCryptoJs.DehydratedDeviceKey.createKeyFromArray(bytes); |
There was a problem hiding this comment.
bytes should be zeroed out after this line, to avoid keeping the key in memory
| @@ -190,7 +202,7 @@ export class DehydratedDeviceManager { | |||
| * Returns whether or not a dehydrated device was found. | |||
| */ | |||
| public async rehydrateDeviceIfAvailable(): Promise<boolean> { | |||
| const key = await this.getKey(false); | |||
| const key = (await this.getCachedKey()) || (await this.getKey(false)); | |||
There was a problem hiding this comment.
Why is getCachedKey called, when getKey already calls getCachedKey and returns its value if it's non-empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4483
Draft because depends on rust-sdk: matrix-org/matrix-rust-sdk#4399 and needs new wasm bindings version.
Added basic support to cache created keys and read from store instead of in memory.
Then adding some basic signalling to DeviceDehydrationManager, helpfull for tests and also for apps to have some feedbacks on device rehydration (reports progress for example)
Checklist
public/exportedsymbols have accurate TSDoc documentation.