Make sending ContentLoaded optional for a widgetClient #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/allow-disable-send-content-loaded-embedded-client
branch
from
5f32139 to
7dd89c8
Compare
toger5
changed the title
toger5
changed the title
toger5
force-pushed
the
toger5/allow-disable-send-content-loaded-embedded-client
branch
from
7dd89c8 to
82bd422
Compare
Signed-off-by: Timo K <[email protected]>
toger5
force-pushed
the
toger5/allow-disable-send-content-loaded-embedded-client
branch
from
82bd422 to
3c1ac5a
Compare
richvdh
previously requested changes
Mar 1, 2024
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
toger5
force-pushed
the
toger5/allow-disable-send-content-loaded-embedded-client
branch
from
0ddc503 to
9ca48f8
Compare
dbkr
reviewed
Mar 5, 2024
Signed-off-by: Timo K <[email protected]>
dbkr
approved these changes
Mar 5, 2024
toger5
dismissed
richvdh’s stale review
Documentation is written/corrected and I have added tests.
Signed-off-by: Timo K <[email protected]>
toger5
deleted the
toger5/allow-disable-send-content-loaded-embedded-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element call we want to have control over the sendContentLoaded action. As soon as we sent this action the widget will be shown.
However we need to adjust the theme first before we show the widget to not have an awkward flash of the wrong theme during the widget loading procedure.
So this should not be sent by the js-sdk and instead be sent by element call after the theme has been setup.
Signed-off-by: Timo K [email protected]
Checklist