Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying OIDC url state parameter for passing data to callback #4068

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Allow specifying OIDC url state parameter for passing data to callback #4068

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c7e3543
Allow specifying more OIDC client metadata for dynamic registration
t3chguy Feb 15, 2024
a84a0df
Allow specifying url_state for dynamic oidc client registration
t3chguy Feb 15, 2024
1a07c77
Export NonEmptyArray type
t3chguy Feb 15, 2024
9248493
Allow specifying more OIDC client metadata for dynamic registration
t3chguy Feb 15, 2024
a69513c
Export NonEmptyArray type
t3chguy Feb 15, 2024
7bd39e7
Fix test
t3chguy Feb 16, 2024
4a8e928
Merge branch 't3chguy/oidc-metadata' into t3chguy/oidc-desktop
t3chguy Feb 16, 2024
c375df6
Merge branch 'develop' into t3chguy/oidc-desktop
t3chguy Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/oidc/authorize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export const generateAuthorizationUrl = async (
* @param nonce - state
* @param prompt - indicates to the OP which flow the user should see - eg login or registration
* See https://openid.net/specs/openid-connect-prompt-create-1_0.html#name-prompt-parameter
* @param urlState - value to append to the opaque state identifier to uniquely identify the callback
* @returns a Promise with the url as a string
*/
export const generateOidcAuthorizationUrl = async ({
Expand All @@ -139,6 +140,7 @@ export const generateOidcAuthorizationUrl = async ({
identityServerUrl,
nonce,
prompt,
urlState,
}: {
clientId: string;
metadata: ValidatedIssuerMetadata;
Expand All @@ -147,8 +149,9 @@ export const generateOidcAuthorizationUrl = async ({
redirectUri: string;
nonce: string;
prompt?: string;
urlState?: string;
}): Promise<string> => {
const scope = await generateScope();
const scope = generateScope();
const oidcClient = new OidcClient({
...metadata,
client_id: clientId,
Expand All @@ -164,6 +167,7 @@ export const generateOidcAuthorizationUrl = async ({
state: userState,
nonce,
prompt,
url_state: urlState,
});

return request.url;
Expand Down
Loading