Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element R: emit events when devices have changed #4019

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Element R: emit events when devices have changed #4019

merged 5 commits into from
Jan 31, 2024

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jan 20, 2024 •
edited by github-actions bot
Loading

Depends on matrix-org/matrix-rust-sdk-crypto-wasm#88 (so tests are expected to fail which is now merged). Fixes element-hq/element-web#26263

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@uhoreg uhoreg marked this pull request as ready for review January 30, 2024 22:28
@uhoreg uhoreg requested review from a team as code owners January 30, 2024 22:28
andybalaam
andybalaam approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

BillCarsonFr
BillCarsonFr approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, thx!

@uhoreg uhoreg added this pull request to the merge queue Jan 31, 2024
Merged via the queue into matrix-org:develop with commit d178fbf Jan 31, 2024
24 checks passed
@uhoreg uhoreg deleted the devices_updated_callback branch January 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element-R: User info panel not updated when user creates or deletes devices
3 participants
@uhoreg @andybalaam @BillCarsonFr