Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: improve logging for secret gossiping #4018

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Element-R: improve logging for secret gossiping #4018

merged 1 commit into from
Jan 19, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jan 19, 2024 •
edited by github-actions bot
Loading

Quick improvements on logs for secret gossiping

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Jan 19, 2024
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner January 19, 2024 10:10
@BillCarsonFr BillCarsonFr force-pushed the valere/element-r/quick_log_improvement branch from be1b43c to 653bf25 Compare January 19, 2024 10:11
@richvdh richvdh changed the title logs: improve logging Element-R: improve logging for secret gossiping Jan 19, 2024
richvdh
richvdh approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm

@BillCarsonFr BillCarsonFr added this pull request to the merge queue Jan 19, 2024
Merged via the queue into develop with commit 22db9eb Jan 19, 2024
27 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/element-r/quick_log_improvement branch January 19, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @richvdh