Fix new threads not appearing. #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to update the thread roots when creating a thread, but a thread can take some time to be ready after being created so we were calling it too soon. Add a listener for the Update event to update the thread roots once it's ready. Fixes element-hq/element-web#26799
and also add a comment to the test
dbkr
commented
Jan 16, 2024
| @@ -363,7 +369,7 @@ export class Thread extends ReadReceipt<ThreadEmittedEvents, ThreadEventHandlerM | |||
| * to the start (and not the end) of the timeline. | |||
| * @param emit - whether to emit the Update event if the thread was updated or not. | |||
| */ | |||
| public async addEvent(event: MatrixEvent, toStartOfTimeline: boolean, emit = true): Promise<void> { | |||
| public addEvent(event: MatrixEvent, toStartOfTimeline: boolean, emit = true): void { | |||
There was a problem hiding this comment.
This was unnecessarily async. I fixed it but that set sonarcloud off on the function complexity, so I had to pull a chunk of it out to reduce the complexity. I can pull this out to a separate PR if necessary but hopefully it's obvious enough what's going on.
There was a problem hiding this comment.
so I had to pull a chunk of it out to reduce the complexity.
You can just mark it as won't fix via the Sonarcloud Web UI instead
There was a problem hiding this comment.
ah okay, good to know. I assumed it wouldn't let me do that with code complexity.
robintown
approved these changes
Jan 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to update the thread roots when creating a thread, but a thread can take some time to be ready after being created so we were calling it too soon. Add a listener for the Update event to update the thread roots once it's ready.
Fixes element-hq/element-web#26799
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes