Support for migration from libolm #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/element-r/migration_groundwork
branch
from
3310a11 to
cf7b115
Compare
richvdh
force-pushed
the
rav/element-r/migration/core
branch
2 times, most recently
from
489ce34 to
cbac65f
Compare
richvdh
force-pushed
the
rav/element-r/migration/core
branch
2 times, most recently
from
971471f to
8c1e897
Compare
This will be faster if we need to prepare the store.
richvdh
force-pushed
the
rav/element-r/migration/core
branch
from
8c1e897 to
7252f7e
Compare
BillCarsonFr
approved these changes
Jan 11, 2024
| const testOlmMachine = makeTestOlmMachine(); | ||
| jest.spyOn(OlmMachine, "initialize").mockResolvedValue(testOlmMachine); | ||
| jest.spyOn(OlmMachine, "init_from_store").mockResolvedValue(testOlmMachine); |
There was a problem hiding this comment.
Surprised to see snake case. A missing jsName in wasm bindings?
There was a problem hiding this comment.
yeah :(. Unfortunately fixing it will mean a new release of the bindings. I'll leave it for now and fix it in a future version of the bindings.
There was a problem hiding this comment.
t3chguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3964.
Here's what your changelog entry will look like:
✨ Features