Don't remove thread info from a thread root when it is redacted #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the redacted event is moving to the main timeline, the redaction belongs there too, since its relationship to the redacted event is the only thing making it part of the thread.
…o-main-when-actioned Move the redaction event to main at the same time we move redacted
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andybalaam
deleted the
andybalaam/dont-remove-thread-info-from-redacted-root
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change moved threaded messages into the main timeline when they were redacted.
I realised we should not do this to thread roots, as they need to stay "in" both the main timeline and the thread, so we can render a thread UI from them, even though they are redacted.
Part of element-hq/element-web#24392
Here's what your changelog entry will look like:
🐛 Bug Fixes