Fix reemitter not being correctly wired on user objects created in storage classes #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
commented
Oct 17, 2023
| * Set the user creator which is used for creating User objects | ||
| * @param creator - A callback that accepts an user-id and returns an User object | ||
| */ | ||
| setUserCreator(creator: UserCreator): void; |
There was a problem hiding this comment.
Temporary solution until we fix element-hq/element-web#26383
germain-gg
suggested changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage classes -
memory.tsandindexeddb.tsboth create user objects without setting it up to emit events on matrix client.This is sometimes preventing the memberlist from updating on incoming presence events because this listener never runs.
Here's what your changelog entry will look like:
🐛 Bug Fixes