Skip to content

Commit

Permalink
Change latest node ver to '*' (#3831)
Browse files Browse the repository at this point in the history
* Change latest node ver to '*'

This uses the latest cached version rather than fetching the latest released version so we don't reply on (and hammer) node's download servers for the very latest version before the actions runners get updated. We'll still stay current, just not quite so aggressively current.

* Fix artifact uploading hopefully

* Hopefully make job name 'node latest'
  • Loading branch information
dbkr authored Oct 24, 2023
1 parent d750e33 commit f941fd8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,19 @@ env:
ENABLE_COVERAGE: ${{ github.event_name != 'merge_group' }}
jobs:
jest:
name: "Jest [${{ matrix.specs }}] (Node ${{ matrix.node }})"
name: "Jest [${{ matrix.specs }}] (Node ${{ matrix.node == '*' && 'latest' || matrix.node }})"
runs-on: ubuntu-latest
timeout-minutes: 10
strategy:
matrix:
specs: [integ, unit]
node: [18, latest]
node: [18, "*"]
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node
id: setupNode
uses: actions/setup-node@v3
with:
cache: "yarn"
Expand Down Expand Up @@ -51,7 +52,7 @@ jobs:

- name: Move coverage files into place
if: env.ENABLE_COVERAGE == 'true'
run: mv coverage/lcov.info coverage/${{ matrix.node }}-${{ matrix.specs }}.lcov.info
run: mv coverage/lcov.info coverage/${{ steps.setupNode.output.node-version }}-${{ matrix.specs }}.lcov.info

- name: Upload Artifact
if: env.ENABLE_COVERAGE == 'true'
Expand Down

0 comments on commit f941fd8

Please sign in to comment.