This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Add GetDisplayName() method #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might be nice to have a helper of osmething like |
t3chguy
reviewed
Aug 22, 2017
responses.go
Outdated
| @@ -90,6 +90,11 @@ type RespUserInteractive struct { | |||
| Error string `json:"error"` | |||
| } | |||
|
|
|||
| // RespUserDisplayName is the JSON response for https://matrix.org/docs/spec/client_server/r0.2.0.html#get-matrix-client-r0-profile-userid-displayname | |||
There was a problem hiding this comment.
I'm gonna complain about the placement of this, you're splitting the above struct from its methods below
There was a problem hiding this comment.
Oh didn't saw that method :)
|
LGTM |
|
So is #36 done? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing GetDisplayName() method.
( Thanks to @t3chguy for the snippet )