Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support napari>=0.5 #274

Merged
merged 11 commits into from
Oct 1, 2024
Merged

Support napari>=0.5 #274

merged 11 commits into from
Oct 1, 2024

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jul 12, 2024

@dstansby dstansby added this to the 3.0 milestone Jul 12, 2024
@samcunliffe
Copy link
Collaborator

The tests fail because of this (significant) diff in the data ...

result-failed-diff

baseline

result

@samcunliffe
Copy link
Collaborator

@dstansby I claim a fix here 🚀

The

OverflowError: Python integer -1 out of bounds for uint8

was fixed by -1 → -1.0 🙃

I've somehow managed to push to your fork, so I can approve this, but I'll wait for you to click merge.
(Also, we need to be sure to squash merge because there are images changed and changed back in the history here.)

@samcunliffe samcunliffe self-requested a review October 1, 2024 09:04
@samcunliffe samcunliffe added Maintenance dependencies Pull requests that update a dependency file labels Oct 1, 2024
@samcunliffe
Copy link
Collaborator

pre-commit.ci autofix

@samcunliffe
Copy link
Collaborator

pre-commit.ci run

@dstansby
Copy link
Member Author

dstansby commented Oct 1, 2024

I think the mypy error is because pre-commit is running a version of numpy (I can't work out which...) that doesn't have a shape argument to np.reshape(), which indeed seems only to have been added in 2.1.0: numpy/numpy#26292. I think we want to support older numpy versions than that, so I think the fix is to revert to using the newshape argument, and ignoring the deprecation warning (for now, until we depend on numpy>=2.1)

@samcunliffe
Copy link
Collaborator

so I think the fix is to revert to using the newshape argument, and ignoring the deprecation warning (for now, until we depend on numpy>=2.1)

Thanks for the detective work! I was just playing 🔨

@dstansby dstansby merged commit 7e860f5 into matplotlib:main Oct 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants