Generalise functionality for plotting from feature tables #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
generalise-features
branch
from
ec8eabf
to
ef5e858
Compare
dstansby
force-pushed
the
generalise-features
branch
from
fc303c2
to
a04bd18
Compare
|
I started writing tests, and this turned into a bit of a multiple inheritance mess. Going to close in favour of implementing a second widget that uses features, and then slowly de-duplicating functionalty after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently one widget that plots data stored in the
.featuresattribute of layers (FeaturesScatterWidget). There is demand to add more of these though, see #61, #63, #148, #60, #58This PR separates the functionality for plotting from a features layer into a new class, which will make it much easier to expand the widgets that plot from features in the future.