make sure updates can run after bootstrap #958
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Matomo forums. There might be relevant details there: https://forum.matomo.org/t/errror-after-update-to-matomo-5-2/61622/6 |
snake14
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Thank you for taking the time to create this PR. It looks good to me 👍
Any objections merging this @AltamashShaikh ?
AltamashShaikh
approved these changes
Dec 17, 2024
|
@snake14 I will merge and fix the PHPCS issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When Matomo bootstraps, it can stop the upgrade to 5.2.0 as the array
key
$container['isTagFireLimitAllowedInPreviewMode']in some cases is accessed in Context/BaseContext.php.The suggested patch sets
$isTagFireLimitAllowedInPreviewMode = 0as default and checks if array key exists forisTagFireLimitAllowedInPreviewMode.Fixes: #959
Review