Added the ability to copy triggers and variables

[snake14]

Description:

This PR adds the ability to copy triggers and variables in Matomo Tag Manager. If the trigger or variable references any variables, it will try to reuse any existing variables. If there aren't any matches in the destination container, it will copy the referenced variables as well.

Fixes: #914 #932

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[AltamashShaikh]

@snake14 Found 1 edge case

1. Copy a trigger
2. It will display the success notification with the URL to navigate
3. Now delete the new copied variable and you will see the notification still stays and it takes you to an empty edit trigger

[AltamashShaikh]

@snake14 Should we add a note here, explaining that for customVariables if its referring to any other customVariable, that will not be copied ?

[AltamashShaikh]

@snake14 Looks good to me left 2 comments rest works as expected.

[snake14]

@snake14 Should we add a note here, explaining that for customVariables if its referring to any other customVariable, that will not be copied ?

@AltamashShaikh I don't think that's necessary, because it does copy referenced variables, unless there's a similar one already existing. So, if you're copying to the same container, it reuses the referenced variables. If copying to a different container, it checks if any variables in that container match the referenced variable before making a copy. That's the behaviour for copying containers, tags, triggers, and variables.

Is that not the behaviour that you're seeing?

[snake14]

@snake14 Found 1 edge case

1. Copy a trigger
2. It will display the success notification with the URL to navigate
3. Now delete the new copied variable and you will see the notification still stays and it takes you to an empty edit trigger

Thank you for catching that @AltamashShaikh . I updated the view to hide the success notification when I trigger is deleted. I went ahead and applied the same change for containers, tags, and variables as well.

[AltamashShaikh]

n't think that's necessary, because it does copy referenced variables, unless there's a similar one already existing. So, if you're copying to the same container, it reuses the referenced variables. If copying to a different container, it checks if any variables in that container match the referenced variable before making a copy. That's the behaviour for copying containers, tags, triggers, and variables.

Okay 👍