apply some review feedback

matomo-org · Sep 15, 2023 · 86d11a1 · 86d11a1
1 parent 215f276
commit 86d11a1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/SiteContentDetection/SpaPwa.php b/SiteContentDetection/SpaPwa.php
@@ -33,7 +33,7 @@ public static function getPriority(): int
         return 70;
     }
 
-    public function detectByContent(?string $data = null, ?array $headers = null): bool
+    public function isDetected(?string $data = null, ?array $headers = null): bool
     {
         return false;
     }
@@ -43,7 +43,7 @@ public function shouldShowInstructionTab(SiteContentDetector $detector = null):
         return true;
     }
 
-    public function renderInstructionsTab(SiteContentDetector $detector = null): string
+    public function renderInstructionsTab(SiteContentDetector $detector): string
     {
         $model = StaticContainer::get('Piwik\Plugins\TagManager\Model\Container');
         $view = new View("@TagManager/trackingSPA");