Merge pull request #964 from matomo-org/PG-3794-add-note-custom-html

Adds a note in CustomHTML tag for remarketing consent, #PG-3794

TagManager.php

@@ -955,6 +955,7 @@ public function getClientSideTranslationKeys(&$result)
         $result[] = 'TagManager_TriggerLowercase';
         $result[] = 'TagManager_VariableLowercase';
         $result[] = 'TagManager_LearnMoreFullStop';
+        $result[] = 'TagManager_CustomHTMLTagNameInlineHelpText';
     }
 
     public function getStylesheetFiles(&$stylesheets)

lang/en.json

@@ -1113,6 +1113,7 @@
         "CopyContainerNote": "%1$sNote:%2$s The copied container may need adjustments if it includes custom code or references specific to the original website. Review settings to ensure compatibility.",
         "CopyXDescription": "To duplicate this %1$s, select the website and container you’d like to add the %1$s to. This will create an exact copy of all settings of the %1$s.",
         "CopyXSuccess": "A copy was successfully created. %1$sNavigate to the new %2$s now%3$s.",
-        "LearnMoreFullStop": "%1$sLearn more%2$s."
+        "LearnMoreFullStop": "%1$sLearn more%2$s.",
+        "CustomHTMLTagNameInlineHelpText": "%1$sNote:%2$s If you are targeting users in Europe, be aware that triggering retargeting tags like Google Ads Remarketing requires user consent under GDPR. %3$sLearn more%4$s."
     }
 }

vue/src/Tag/TagEdit.vue

@@ -44,7 +44,7 @@
               @update:model-value="tag.name = $event; setValueHasChanged()"
               :maxlength="255"
               :title="translate('General_Name')"
-              :inline-help="translate('TagManager_TagNameHelpV2')"
+              :inline-help="tagNameHelpText"
               :placeholder="translate('TagManager_TagNamePlaceholder')"
             />
           </div>
@@ -336,7 +336,7 @@ import {
   NotificationsStore,
   NotificationType,
   clone,
-  MatomoUrl,
+  MatomoUrl, externalLink,
 } from 'CoreHome';
 import { Field, SaveButton, GroupedSettings } from 'CorePluginsAdmin';
 import AvailableFireLimitsStore from '../AvailableFireLimit.store';
@@ -831,6 +831,18 @@ export default defineComponent({
         translate('TagManager_OnceLifetime'),
       );
     },
+    tagNameHelpText() {
+      let additionalHelpText = '';
+      console.log(this.tag);
+      if (this.tag.type === 'CustomHtml') {
+        additionalHelpText = translate('TagManager_CustomHTMLTagNameInlineHelpText',
+          '<br><br><strong>',
+          '</strong>',
+          externalLink('https://matomo.org/faq/tag-manager/how-to-add-google-ads-remarketing-tags-in-matomo-tag-manager/'),
+          '</a>');
+      }
+      return translate('TagManager_TagNameHelpV2') + additionalHelpText;
+    },
   },
 });
 </script>