Moves FormElement variable under forms categpry, #PG-4057

matomo-org · Dec 13, 2024 · 09beb4b · 09beb4b
1 parent cf90dde
commit 09beb4b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 21 deletions.
diff --git a/Template/Variable/PreConfigured/FormElement.php b/Template/Variable/PreConfigured/FormElement.php
@@ -13,7 +13,7 @@ class FormElement extends BaseDataLayerVariable
 {
     public function getCategory()
     {
-        return self::CATEGORY_CLICKS;
+        return self::CATEGORY_FORMS;
     }
 
     protected function getDataLayerVariableName()

diff --git a/tests/System/expected/test_no_content__TagManager.getAvailableContainerVariables.xml b/tests/System/expected/test_no_content__TagManager.getAvailableContainerVariables.xml
@@ -73,16 +73,6 @@
 				<order>9999</order>
 				<is_pre_configured>1</is_pre_configured>
 			</row>
-			<row>
-				<id>FormElement</id>
-				<idvariable />
-				<type>FormElement</type>
-				<name>Form Element</name>
-				<category>Clicks</category>
-				<description>An instance of the element that was submitted.</description>
-				<order>9999</order>
-				<is_pre_configured>1</is_pre_configured>
-			</row>
 		</types>
 	</row>
 	<row>
@@ -328,6 +318,16 @@
 				<order>9999</order>
 				<is_pre_configured>1</is_pre_configured>
 			</row>
+			<row>
+				<id>FormElement</id>
+				<idvariable />
+				<type>FormElement</type>
+				<name>Form Element</name>
+				<category>Forms</category>
+				<description>An instance of the element that was submitted.</description>
+				<order>9999</order>
+				<is_pre_configured>1</is_pre_configured>
+			</row>
 			<row>
 				<id>FormId</id>
 				<idvariable />

diff --git a/tests/System/expected/test_with_content__TagManager.getAvailableContainerVariables.xml b/tests/System/expected/test_with_content__TagManager.getAvailableContainerVariables.xml
@@ -73,16 +73,6 @@
 				<order>9999</order>
 				<is_pre_configured>1</is_pre_configured>
 			</row>
-			<row>
-				<id>FormElement</id>
-				<idvariable />
-				<type>FormElement</type>
-				<name>Form Element</name>
-				<category>Clicks</category>
-				<description>An instance of the element that was submitted.</description>
-				<order>9999</order>
-				<is_pre_configured>1</is_pre_configured>
-			</row>
 		</types>
 	</row>
 	<row>
@@ -363,6 +353,16 @@
 				<order>9999</order>
 				<is_pre_configured>1</is_pre_configured>
 			</row>
+			<row>
+				<id>FormElement</id>
+				<idvariable />
+				<type>FormElement</type>
+				<name>Form Element</name>
+				<category>Forms</category>
+				<description>An instance of the element that was submitted.</description>
+				<order>9999</order>
+				<is_pre_configured>1</is_pre_configured>
+			</row>
 			<row>
 				<id>FormId</id>
 				<idvariable />