Added an option to retain the case of campaign parameter values via SystemSetting, #PG-2343

[AltamashShaikh]

Description:

Added an option to retain the case of campaign parameter values via SystemSetting
Fixes: #PG-2343, #27

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

@AltamashShaikh It might be better to use a solution as I described here: #65 (comment)
The problem with your solution is, that it might slow down tracking, as it needs to read the system setting for every single tracking request to check if the setting is enabled or disabled.
It could also be an idea to use a config flag instead of a system setting. That way we could even allow to easily configure that per site.

[snake14]

Looks good. Worked as expected when tested, including migration 👍

[AltamashShaikh]

@AltamashShaikh It might be better to use a solution as I described here: #65 (comment) The problem with your solution is, that it might slow down tracking, as it needs to read the system setting for every single tracking request to check if the setting is enabled or disabled. It could also be an idea to use a config flag instead of a system setting. That way we could even allow to easily configure that per site.

@sgiehl Changed to change the case during archiving, can you check if this look good to you ?

[sgiehl]

Left some suggestions for possible improvements. Besides that the approach looks fine that way 👍

[snake14]

Nice work! I like that it does the processing during archiving. I confirmed that I could invalidate and archive and see the setting change reflected in the report 👍