Change no data page logic according to core changes #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
refactornodatapage
branch
2 times, most recently
from
e89a1c3 to
02e45a8
Compare
sgiehl
force-pushed
the
refactornodatapage
branch
from
02e45a8 to
827fcfe
Compare
|
@AltamashShaikh We have completely refactored how the no data screen works in Matomo. The changes here will adjust this plugin, so it show the tab as before. The changes will be part of Matomo 5.0.0-rc3, which was not yet released. Once that was released we might need to release a new version of this plugin with the changes in that PR as well. |
| return [ | ||
| SiteContentDetector::class => \Piwik\DI::autowire(FakeSiteContentDetector::class) | ||
| ->constructorParameter('mockData', $mockData) | ||
| ->constructorParameter('detectedContentDetections', [Cloudflare::getId(), GoogleAnalytics3::getId()]) |
There was a problem hiding this comment.
@sgiehl Similar changes would be required in ConenctAccounts and Cloud plugin
AltamashShaikh
approved these changes
Sep 18, 2023
| @@ -7,6 +7,9 @@ | |||
| */ | |||
| namespace Piwik\Plugins\GoogleAnalyticsImporter\tests\Fixtures; | |||
|
|
|||
| use Piwik\Plugins\SEO\Metric\Google; | |||
There was a problem hiding this comment.
@sgiehl This use is required?
|
@AltamashShaikh applied your feedback |
AltamashShaikh
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With matomo-org/matomo#21029 the handling of no data page will be fully refactored. This PR includes the requires changes for this plugin to work with the new core code.
Review