Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure empty plugin settings are saved correctly [5.x] #22891

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Ensure empty plugin settings are saved correctly [5.x] #22891

merged 1 commit into from
Dec 20, 2024
+56 −15

Conversation

michalkleiner
Copy link
Contributor

Description:

Cherry pick of #22885 to 5.x as the original fix was done in a patch release branch.

Review

@michalkleiner
Ensure empty plugin settings are saved correctly
6b4aac2 
* Send and process empty setting arrays as __empty__ value
* Add integration test for an empty settings array
@michalkleiner michalkleiner added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 20, 2024
@michalkleiner michalkleiner requested a review from a team December 20, 2024 11:13
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 20, 2024
@sgiehl sgiehl merged commit d3d1d35 into 5.x-dev Dec 20, 2024
24 of 26 checks passed
@sgiehl sgiehl deleted the dev-18796-5x branch December 20, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @sgiehl