Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass in secrets to test action #22865

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Allow to pass in secrets to test action #22865

merged 1 commit into from
Dec 16, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 15, 2024

Description:

Preview releases are currently failing due to an error:

Invalid workflow file: .github/workflows/release-preview.yml#L161
The workflow is not valid. .github/workflows/release-preview.yml (Line: 161, Col: 23): Invalid secret, ARTIFACTS_PASS is not defined in the referenced workflow.

This PR aims to fix that.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 15, 2024
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 15, 2024
@sgiehl sgiehl requested a review from a team December 15, 2024 21:32
@sgiehl sgiehl merged commit 153f637 into 5.x-dev Dec 16, 2024
26 checks passed
@sgiehl sgiehl deleted the definesecrets branch December 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants