Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer version of php-di (v7) #22863

Closed
wants to merge 1 commit into from

Conversation

williamdes
Copy link
Contributor

Description:

By reading: https://php-di.org/doc/migration/7.0.html The code uses useAnnotations(false);, that means no annotation needs to be changed.
And there is no use of buildDevContainer

No changes to the lock file are to be expected, since PHP 7 support is still needed.

Review

By reading: https://php-di.org/doc/migration/7.0.html
The code uses `useAnnotations(false);`, that means no annotation needs to be changed.
And there is no use of `buildDevContainer`
@sgiehl
Copy link
Member

sgiehl commented Dec 16, 2024

Hey @williamdes,

Thanks for creating this (and the other PRs) around updating some composer packages.
Unfortunately we can't merge them.
Matomo is delivered as a package that includes all external libraries. Therefore all libraries included need to be compatible with the lowest PHP that is supported.
We could for sure simply add such optional versions, so people installing it from source could use newer libs, but that would require that we do a thorough testing with all versions we support. And this isn't something we want to provide atm.
Therefor we will stick to the currently defined versions until we drop support for PHP 7, which might happen in the next major release.

@sgiehl sgiehl closed this Dec 16, 2024
@williamdes williamdes deleted the php-di-upgrade branch December 16, 2024 22:48
@williamdes
Copy link
Contributor Author

Hey @williamdes,

Thanks for creating this (and the other PRs) around updating some composer packages. Unfortunately we can't merge them. Matomo is delivered as a package that includes all external libraries. Therefore all libraries included need to be compatible with the lowest PHP that is supported. We could for sure simply add such optional versions, so people installing it from source could use newer libs, but that would require that we do a thorough testing with all versions we support. And this isn't something we want to provide atm. Therefor we will stick to the currently defined versions until we drop support for PHP 7, which might happen in the next major release.

Hello
For sure, I understand this very well.
You can keep my PRs in mind and cherry-pick them when needed.
Users that need the patch can find it
Feel free to ping me when neeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants