Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade composer/semver #22862

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

williamdes
Copy link
Contributor

Description:

I did review the uses in your code base and all the changelogs of composer/semver.
There is no breaking change to be expected, we can use the last version.

Review

@sgiehl
Copy link
Member

sgiehl commented Dec 16, 2024

This update seems legit. I'll rebase the PR to see if any tests are failing. Otherwise this would be good to merge I guess.

@sgiehl sgiehl added the dependencies PRs that update some dependencies, e.g. composer dependencies or git submodules label Dec 16, 2024
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 16, 2024
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure is unrelated. So looks good to merge. Thanks for the contribution @williamdes

@sgiehl sgiehl merged commit c161fe8 into matomo-org:5.x-dev Dec 16, 2024
24 of 26 checks passed
@williamdes williamdes deleted the composer-upgrade branch December 16, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update some dependencies, e.g. composer dependencies or git submodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants