Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of jshrink #22861

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

williamdes
Copy link
Contributor

Previous update: #17112

Description:

There is no breaking changes to be expected, some versions between the two had removed PHP 7 support.
But it was added back in https://github.com/tedious/JShrink/releases/tag/v1.6.5

Review

@sgiehl
Copy link
Member

sgiehl commented Dec 16, 2024

@williamdes If the new version is also compatible with PHP 7.2, we should update the composer.lock here, to ensure it's used for newer releases. But maybe should wait till the other PR is merged (if possible) to avoid merge conflicts..

@williamdes
Copy link
Contributor Author

@williamdes If the new version is also compatible with PHP 7.2, we should update the composer.lock here, to ensure it's used for newer releases. But maybe should wait till the other PR is merged (if possible) to avoid merge conflicts..

Indeed, done and rebased

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all passing, so looks good to merge. Thanks for the contribution @williamdes

@sgiehl sgiehl added this to the 5.3.0 milestone Dec 17, 2024
@sgiehl sgiehl added the dependencies PRs that update some dependencies, e.g. composer dependencies or git submodules label Dec 17, 2024
@sgiehl sgiehl merged commit e8c4411 into matomo-org:5.x-dev Dec 17, 2024
26 checks passed
@williamdes williamdes deleted the jsshrink-upgrade branch December 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update some dependencies, e.g. composer dependencies or git submodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants