Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use segment length to make dropdown responsive #22849

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Use segment length to make dropdown responsive #22849

merged 6 commits into from
Dec 17, 2024

Conversation

nathangavin
Copy link
Contributor

@nathangavin nathangavin commented Dec 12, 2024

Above 600px, the dropdown has a min width of 240px, and a max width of 320px. The width of the dropdown will grow to match the longest segment name.

Below 600px, the width of the dropdown is fixed to the same size as the parent button.

fixes #21291

Review

Above 600px, the dropdown has a min width of 240px, and a max width of
320px. The width of the dropdown will grow to match the longest segment
name.

Below 600px, the width of the dropdown is fixed to the same size as the
parent button.
@nathangavin nathangavin marked this pull request as ready for review December 13, 2024 02:05
@nathangavin nathangavin requested a review from a team December 13, 2024 02:05
@nathangavin nathangavin added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Dec 13, 2024
@mneudert mneudert added this to the 5.3.0 milestone Dec 16, 2024
@nathangavin nathangavin merged commit 80576a0 into 5.x-dev Dec 17, 2024
26 checks passed
@nathangavin nathangavin deleted the dev-17218 branch December 17, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
2 participants