Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoreHome global property typing #22802

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix CoreHome global property typing #22802

merged 1 commit into from
Nov 26, 2024

Conversation

mneudert
Copy link
Member

Description:

While working on #22751 the types for the global formatting functions got messed up. This seems to be no problem with the current build, but the next update (#22707) would break:

[tsl] ERROR in /home/runner/work/matomo/matomo/plugins/CoreHome/vue/src/createVueApp.ts(31,3)
TS2322: Type '(val: string | number, maxFractionDigits?: number | undefined, minFractionDigits?: number | undefined, noSign?: boolean | undefined) => string' is not assignable to type '(val: string, cur: string, maxFractionDigits?: number | undefined, minFractionDigits?: number | undefined, noSign?: boolean | undefined) => string'.
Types of parameters 'maxFractionDigits' and 'cur' are incompatible.
Type 'string' is not assignable to type 'number | undefined'.

Review

@mneudert mneudert added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 26, 2024
@mneudert mneudert added this to the 5.2.0 milestone Nov 26, 2024
@mneudert mneudert requested a review from a team November 26, 2024 17:22
@sgiehl sgiehl merged commit ea07d10 into 5.x-dev Nov 26, 2024
25 of 26 checks passed
@sgiehl sgiehl deleted the fix-ts-typing branch November 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants