Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link feature gates to marketplace plugin details #22168

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Link feature gates to marketplace plugin details #22168

merged 3 commits into from
Apr 29, 2024

Conversation

mneudert
Copy link
Member

Description:

Updates the links on the promo widgets to the redesigned marketplace modals.

Does not take any other action than scrolling the plugin card into view while opening the new modal. A trial will have to be started manually as a second click, as the CTA button on the promo widgets is currently shown to some users not actually able to start a free trial on their own.

Requires #22139 to be merged first
Refs DEV-18003

Review

@mneudert mneudert added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review c: Premium plugins For bugs and features related to premium plugins. labels Apr 26, 2024
@mneudert mneudert added this to the 5.1.0 milestone Apr 26, 2024
@mneudert mneudert requested a review from a team April 26, 2024 15:42
Base automatically changed from dev-17986 to 5.x-dev April 29, 2024 08:35
@mneudert mneudert merged commit 83a15d3 into 5.x-dev Apr 29, 2024
21 of 25 checks passed
@mneudert mneudert deleted the dev-18003 branch April 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Premium plugins For bugs and features related to premium plugins. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants