Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coding Style] Use camel case for method names in remaining tests #22160

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 25, 2024

Description:

refs #22144

Last part of adjusting test files. In this PR PHPCS should already be fixed. After merging this one, we can also merge #22144

Review

@sgiehl sgiehl force-pushed the psr12_camelcapsmethods_10 branch from 19f1aca to bcd394b Compare April 25, 2024 12:36
@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Technical debt Issues the will help to reduce technical debt labels Apr 25, 2024
@sgiehl sgiehl requested a review from a team April 25, 2024 13:05
@mneudert mneudert merged commit f5e16d2 into psr12_camelcapsmethods Apr 25, 2024
20 of 25 checks passed
@mneudert mneudert deleted the psr12_camelcapsmethods_10 branch April 25, 2024 16:05
mneudert pushed a commit that referenced this pull request Apr 25, 2024
…2160)

* [Coding Style] Use camel case for method names in remaining tests

* rename expected test files
mneudert pushed a commit that referenced this pull request Apr 25, 2024
…aps (#22144)

* [Coding Style] Enable rule PSR1.Methods.CamelCapsMethodName.NotCamelCaps

* [Coding Style] Use camel case for method names in API plugin tests (#22145)

* [Coding Style] Use camel case for method names in Core* plugin tests (#22147)

* [Coding Style] Use camel case for method names in core Unit tests (#22149)

* [Coding Style] Use camel case for method names in Actions and BulkTracking plugin tests (#22146)

* [Coding Style] Use camel case for method names in CustomDimensions and CustomJSTracker plugin tests (#22148)

* [Coding Style] Use camel case for method names in core Integration tests (#22151)

* [Coding Style] Use camel case for method names in more core plugin tests (#22153)

* [Coding Style] Use camel case for method names in more core plugin tests (#22157)

* [Coding Style] Use camel case for method names in more core plugin tests

* Update plugins/Monolog/tests/Unit/Processor/ExceptionToTextProcessorTest.php

Co-authored-by: Michal Kleiner <[email protected]>

---------

Co-authored-by: Michal Kleiner <[email protected]>

* [Coding Style] Use camel case for method names in more core plugin tests (#22159)

* [Coding Style] Use camel case for method names in remaining tests (#22160)

* [Coding Style] Use camel case for method names in remaining tests

* rename expected test files

---------

Co-authored-by: Michal Kleiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants