Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coding Style] Enable rule PSR12.Properties.ConstantVisibility #22131

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[Coding Style] Enable rule PSR12.Properties.ConstantVisibility #22131

merged 2 commits into from
Apr 18, 2024

Conversation

michalkleiner
Copy link
Contributor

Description:

No file changes necessary when enabling this rule.

Review

@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Technical debt Issues the will help to reduce technical debt labels Apr 17, 2024
@michalkleiner michalkleiner added this to the 5.1.0 milestone Apr 17, 2024
@michalkleiner michalkleiner requested a review from a team April 17, 2024 05:09
sgiehl
sgiehl requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes required, the rule just don't support autofix with phpcfb

@michalkleiner
Copy link
Contributor Author

There are changes required, the rule just don't support autofix with phpcfb

Of course, you're right. Got caught up by this before and forgot about it. Will address that.

@michalkleiner michalkleiner removed the Needs Review PRs that need a code review label Apr 17, 2024
@michalkleiner michalkleiner marked this pull request as draft April 17, 2024 06:17
@michalkleiner michalkleiner marked this pull request as ready for review April 17, 2024 06:42
@michalkleiner michalkleiner requested review from a team and sgiehl April 17, 2024 06:44
@michalkleiner
Copy link
Contributor Author

Made all the constants public (as they were technically), at some point we can review which could/should be private.

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label Apr 17, 2024
@michalkleiner michalkleiner force-pushed the psr12_constantvisibility branch from ed11bc3 to 4a4d7b6 Compare April 17, 2024 22:32
@michalkleiner michalkleiner requested a review from sgiehl April 17, 2024 22:33
@sgiehl sgiehl merged commit 6274865 into 5.x-dev Apr 18, 2024
23 of 25 checks passed
@sgiehl sgiehl deleted the psr12_constantvisibility branch April 18, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @sgiehl