Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coding Style] Enable rule PSR2.Methods.MethodDeclaration.Underscore #22128

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[Coding Style] Enable rule PSR2.Methods.MethodDeclaration.Underscore #22128

merged 2 commits into from
Apr 16, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 15, 2024 •
edited
Loading

Description:

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt labels Apr 15, 2024
Base automatically changed from psr12_elseif to 5.x-dev April 15, 2024 17:32
@sgiehl sgiehl force-pushed the psr12_underscoremethod branch from 004c523 to e5ce666 Compare April 15, 2024 20:31
@sgiehl sgiehl added this to the 5.1.0 milestone Apr 15, 2024
@sgiehl sgiehl requested a review from a team April 15, 2024 20:34
@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 15, 2024
@sgiehl sgiehl merged commit f6d02d9 into 5.x-dev Apr 16, 2024
23 of 25 checks passed
@sgiehl sgiehl deleted the psr12_underscoremethod branch April 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @michalkleiner